CDRIVER-6300 CSFLE/QE Support for HTTP Proxies#2318
Open
mdb-ad wants to merge 3 commits into
Open
Conversation
eramongodb
requested changes
Jun 17, 2026
|
|
||
| /* Returns a connected stream to (host, port). The driver wraps the returned | ||
| * stream with TLS. Return NULL and set @error on failure. */ | ||
| typedef mongoc_stream_t *(BSON_CALL *mongoc_kms_connect_callback_fn)(const char *host, |
Contributor
There was a problem hiding this comment.
Missing documentation for new API (e.g. see mongoc_oidc_callback_fn_t).
| void *userdata); | ||
|
|
||
| MONGOC_EXPORT(void) | ||
| mongoc_auto_encryption_opts_set_kms_connect_callback(mongoc_auto_encryption_opts_t *opts, |
Contributor
There was a problem hiding this comment.
Missing documentation for new API.
| void *userdata); | ||
|
|
||
| MONGOC_EXPORT(void) | ||
| mongoc_client_encryption_opts_set_kms_connect_callback(mongoc_client_encryption_opts_t *opts, |
Contributor
There was a problem hiding this comment.
Missing documentation for new API.
| static int | ||
| _skip_if_no_kms_proxy(void) | ||
| { | ||
| return getenv("MONGOC_TEST_KMS_PROXY_HOST") ? 1 : 0; |
Contributor
There was a problem hiding this comment.
Is this env var set anywhere in CI?
| if (!base_stream) { | ||
| goto fail; | ||
| if (connect_cb && connect_cb->fn) { | ||
| base_stream = connect_cb->fn(host.host, (int32_t)host.port, connect_cb->userdata, error); |
Contributor
There was a problem hiding this comment.
Should connecttimeoutms be forwarded to the callback function?
| /* Returns a connected stream to (host, port). The driver wraps the returned | ||
| * stream with TLS. Return NULL and set @error on failure. */ | ||
| typedef mongoc_stream_t *(BSON_CALL *mongoc_kms_connect_callback_fn)(const char *host, | ||
| int32_t port, |
Contributor
There was a problem hiding this comment.
Suggested change
| int32_t port, | |
| uint16_t port, |
Consistency with mongoc_host_list_t::port:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing with the proxy server (from drivers-evergreen-tools): https://spruce.corp.mongodb.com/version/6a30961530385700079ea274